-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/py color support osg viewer #1398
Conversation
An Eigen::Vector4f can be passed to the viewer constructor to set the background color.
only works for double vectors
Codecov Report
@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
- Coverage 57.38% 57.37% -0.02%
==========================================
Files 366 366
Lines 27405 27405
==========================================
- Hits 15726 15723 -3
- Misses 11679 11682 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the new possibility to one of the dartpy examples?
Yeah, it'd be worth to test it in at least one dartpy
example (maybe hello_world_gui
).
… into fix/pyColorSupportOsgViewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes issue #1393. Allows to set the background color in
dartpy.gui.osg.Viewer
anddartpy.gui.osg.ImGuiViewer
with a type convertible to an Eigen::Vector4d, e.g.Should we add the new possibility to one of the dartpy examples?
The argument type is now
Eigen::Vector4d
(instead ofEigen::Vector4f
), because it allows passing a list as well (as in the creation ofviewer2
above).Before creating a pull request
document new methods and classesclang-format
Before merging a pull request
CHANGELOG.md