Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IkFast parameter accessors to IkFast class #1396

Merged
merged 7 commits into from
Aug 17, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Aug 16, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1396 into master will decrease coverage by 0.1%.
The diff coverage is 17.28%.

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   57.38%   57.28%   -0.11%     
==========================================
  Files         366      366              
  Lines       27405    27483      +78     
==========================================
+ Hits        15726    15743      +17     
- Misses      11679    11740      +61
Impacted Files Coverage Δ
dart/dynamics/SharedLibraryIkFast.hpp 100% <ø> (ø) ⬆️
dart/dynamics/IkFast.hpp 100% <ø> (ø) ⬆️
dart/dynamics/SharedLibraryIkFast.cpp 52.74% <0%> (+3.33%) ⬆️
dart/common/detail/SharedLibraryManager.cpp 75% <100%> (ø) ⬆️
dart/dynamics/IkFast.cpp 59.11% <16.43%> (-24.1%) ⬇️

@jslee02 jslee02 changed the title Expose several IkFast specific APIs in IkFast class Make IkFast specific APIs public in IkFast class Aug 16, 2019
@jslee02 jslee02 changed the title Make IkFast specific APIs public in IkFast class Add IkFast parameter accessors to IkFast class Aug 17, 2019
@jslee02 jslee02 merged commit 660b0f4 into master Aug 17, 2019
@jslee02 jslee02 deleted the enhance/ikfast branch August 17, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant