Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks from dart::gui::osg::Viewer (#1331) #1349

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jun 3, 2019

This PR fixes #1331.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.10.0 milestone Jun 3, 2019
@jslee02 jslee02 requested a review from mxgrey June 3, 2019 05:54
@jslee02 jslee02 marked this pull request as ready for review June 3, 2019 05:56
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #1349 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1349      +/-   ##
==========================================
+ Coverage   56.87%   56.88%   +<.01%     
==========================================
  Files         366      366              
  Lines       27174    27174              
==========================================
+ Hits        15456    15458       +2     
+ Misses      11718    11716       -2
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 65.95% <0%> (-0.17%) ⬇️
dart/dynamics/EulerJoint.cpp 70.73% <0%> (+3.04%) ⬆️

@jslee02 jslee02 merged commit 8feaa46 into master Jun 5, 2019
@jslee02 jslee02 deleted the issue_1331 branch June 5, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two memory leaks in DART::gui::osg::Viewer
1 participant