Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartpy: Add shadow technique #1348

Merged
merged 2 commits into from
Jun 4, 2019
Merged

dartpy: Add shadow technique #1348

merged 2 commits into from
Jun 4, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Jun 3, 2019

Changes

  • Add shadow technique
  • Add OSG biped example
  • Reduced default shadow map resolution

image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 marked this pull request as ready for review June 3, 2019 05:12
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #1348 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
+ Coverage   56.88%   56.89%   +0.01%     
==========================================
  Files         366      366              
  Lines       27174    27174              
==========================================
+ Hits        15458    15461       +3     
+ Misses      11716    11713       -3
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️

@jslee02 jslee02 merged commit 937ed81 into master Jun 4, 2019
@jslee02 jslee02 deleted the dartpy/shadow branch June 4, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant