Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default constructor to RayHit #1345

Merged
merged 3 commits into from
May 30, 2019
Merged

Add default constructor to RayHit #1345

merged 3 commits into from
May 30, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 30, 2019

Necessary to initialize the members. Also, RayHit.mHasHit is removed since it's not used.


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.1 milestone May 30, 2019
@jslee02 jslee02 marked this pull request as ready for review May 30, 2019 13:05
@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #1345 into release-6.9 will decrease coverage by <.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release-6.9    #1345      +/-   ##
===============================================
- Coverage        56.89%   56.89%   -0.01%     
===============================================
  Files              366      366              
  Lines            27174    27177       +3     
===============================================
  Hits             15461    15461              
- Misses           11713    11716       +3
Impacted Files Coverage Δ
dart/collision/RaycastResult.hpp 100% <ø> (ø) ⬆️
dart/collision/RaycastResult.cpp 100% <100%> (ø) ⬆️
dart/dynamics/Skeleton.cpp 65.95% <0%> (-0.17%) ⬇️

@jslee02 jslee02 changed the title Add constructors to RayHit and RaycastResult Add default constructor to RayHit May 30, 2019
@jslee02 jslee02 merged commit ccfc73d into release-6.9 May 30, 2019
@jslee02 jslee02 deleted the raycast_result branch May 30, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant