Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Add shapes and ShapeFrame aspects #1328

Merged
merged 3 commits into from
May 20, 2019
Merged

[dartpy] Add shapes and ShapeFrame aspects #1328

merged 3 commits into from
May 20, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 20, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 20, 2019
@jslee02 jslee02 marked this pull request as ready for review May 20, 2019 14:23
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #1328 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   56.89%   56.89%           
=======================================
  Files         366      366           
  Lines       27167    27167           
=======================================
  Hits        15457    15457           
  Misses      11710    11710

@jslee02 jslee02 merged commit 58e32e2 into master May 20, 2019
@jslee02 jslee02 deleted the dartpy/dnd branch May 20, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant