Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Add SimpleFrame #1326

Merged
merged 5 commits into from
May 20, 2019
Merged

[dartpy] Add SimpleFrame #1326

merged 5 commits into from
May 20, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 19, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 19, 2019
@jslee02 jslee02 marked this pull request as ready for review May 19, 2019 23:42
@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #1326 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   56.91%   56.91%   +<.01%     
==========================================
  Files         366      366              
  Lines       27156    27161       +5     
==========================================
+ Hits        15457    15460       +3     
- Misses      11699    11701       +2
Impacted Files Coverage Δ
dart/dynamics/Entity.hpp 100% <ø> (ø) ⬆️
dart/dynamics/Frame.hpp 87.5% <ø> (ø) ⬆️
dart/dynamics/SimpleFrame.hpp 100% <ø> (ø) ⬆️
dart/dynamics/Frame.cpp 74.62% <0%> (-1.42%) ⬇️
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️

@jslee02 jslee02 merged commit bc52723 into master May 20, 2019
@jslee02 jslee02 deleted the dartpy/simple_frame branch May 20, 2019 02:22
jslee02 added a commit that referenced this pull request May 20, 2019
Update changelog

Update SimpleFrame unit test

dartpy: Remove leading underscore from argument name

dartpy: Add InverseKinematics
jslee02 added a commit that referenced this pull request May 20, 2019
Update changelog

Update SimpleFrame unit test

dartpy: Remove leading underscore from argument name

dartpy: Add InverseKinematics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant