Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dartpy] Allow WorldNode classes to overload virtual functions #1322

Merged
merged 3 commits into from
May 18, 2019

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 18, 2019


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 18, 2019
@jslee02 jslee02 marked this pull request as ready for review May 18, 2019 03:47
@codecov
Copy link

codecov bot commented May 18, 2019

Codecov Report

Merging #1322 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
+ Coverage    57.1%   57.13%   +0.02%     
==========================================
  Files         366      366              
  Lines       27050    27050              
==========================================
+ Hits        15447    15455       +8     
+ Misses      11603    11595       -8
Impacted Files Coverage Δ
dart/dynamics/Skeleton.cpp 66.12% <0%> (+0.16%) ⬆️
dart/dynamics/EulerJoint.cpp 70.73% <0%> (+3.04%) ⬆️

@jslee02 jslee02 merged commit 10ad8e2 into master May 18, 2019
@jslee02 jslee02 deleted the dartpy/world_node branch May 18, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant