Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning of ImGuiViewer + OSG shadow #1312

Merged
merged 3 commits into from
May 10, 2019
Merged

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented May 9, 2019

The incompatibility issue of ImGuiViewer + OSG shadow found in #978 was fixed in #1274. Particularly, these two blocks (1, 2) resolved the issue.

image


Before creating a pull request

  • Document new methods and classes
  • Format new code files using clang-format

Before merging a pull request

  • Set version target by selecting a milestone on the right side
  • Summarize this change in CHANGELOG.md
  • Add unit test(s) for this change (N/A)

@jslee02 jslee02 added this to the DART 6.9.0 milestone May 9, 2019
@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #1312 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
+ Coverage   57.18%   57.19%   +0.01%     
==========================================
  Files         366      366              
  Lines       27023    27023              
==========================================
+ Hits        15452    15457       +5     
+ Misses      11571    11566       -5
Impacted Files Coverage Δ
dart/dynamics/EulerJoint.cpp 70.73% <0%> (+3.04%) ⬆️

@jslee02 jslee02 marked this pull request as ready for review May 10, 2019 01:08
@jslee02 jslee02 merged commit 45d1cae into master May 10, 2019
@jslee02 jslee02 deleted the remove_imgui_warning branch May 10, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants