Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements booleanOverlap and line_overlap function #141

Closed
wants to merge 9 commits into from

Conversation

armantorkzaban
Copy link
Contributor

No description provided.

lib/src/line_overlap.dart Outdated Show resolved Hide resolved
@lukas-h
Copy link
Member

lukas-h commented Dec 20, 2022

@armantorkzaban we should finish this in the next weeks. This is another "low hanging fruit", which can be finished easily

@jsiedentop
Copy link
Contributor

Okay, I need to take a closer look. Some tests fail, and it appears that the implementation is incomplete.

I picked out this ./test/examples/booleans/overlap/true/simple-lines.geojson example, where two lines partially overlap. Unfortunately, our current implementation failed to detect this overlap, whereas turf.js correctly identifies it.

@lukas-h
Copy link
Member

lukas-h commented Feb 8, 2024

@lukas-h lukas-h added enhancement New feature or request blocking labels Feb 8, 2024
@jsiedentop
Copy link
Contributor

I am closing this because the functions were implemented with #174

@jsiedentop jsiedentop closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants