Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register a restart handler directly over the VM service connection #2437

Merged
merged 1 commit into from
May 24, 2024
Merged

Register a restart handler directly over the VM service connection #2437

merged 1 commit into from
May 24, 2024

Conversation

elliette
Copy link
Contributor

@elliette elliette commented May 24, 2024 •
edited
Loading

This is a workaround for a Cider bug, see b/342668928 for details.

@elliette elliette requested a review from helin24 May 24, 2024 21:00
@elliette elliette merged commit 15028c4 into dart-lang:master May 24, 2024
51 of 52 checks passed
@elliette elliette mentioned this pull request May 28, 2024
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 29, 2024
@devoncarew
[deps] rev args, async, benchmark_harness, boolean_selector, collecti…
9c5085e 
…on, dartdoc, markdown, shelf, web, web_socket_channel, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/cf90551..b3608bd):
  b3608bd  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/args#275)

async (https://github.com/dart-lang/async/compare/77a25d7..f933ddf):
  f933ddf  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/async#275)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/accc755..6fa42b0):
  6fa42b0  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/benchmark_harness#106)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/2cbd4a6..84467e5):
  84467e5  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/boolean_selector#61)

collection (https://github.com/dart-lang/collection/compare/4718398..fe2e800):
  fe2e800  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/collection#344)

dartdoc (https://github.com/dart-lang/dartdoc/compare/1e1a004..ed97585):
  ed975850  2024-05-28  Sam Rawlins  Fix flutter CI with re-internalized snippets tool (dart-lang/dartdoc#3776)

markdown (https://github.com/dart-lang/markdown/compare/340c76f..c1013dc):
  c1013dc  2024-05-28  Kevin Moore  update lints dependency (dart-lang/markdown#613)
  7a3b8d6  2024-05-28  Sam Rawlins  Bump to 7.2.3 (dart-lang/markdown#612)

shelf (https://github.com/dart-lang/shelf/compare/d9f82bf..338962c):
  338962c  2024-05-28  Kevin Moore  update lints dependency (dart-lang/shelf#433)

web (https://github.com/dart-lang/web/compare/d776645..f6f778b):
  f6f778b  2024-05-28  Kenzie Davisson  Expose `onUnload` event stream and `ElementStream` as a public class (dart-lang/web#246)
  e1d5148  2024-05-23  Kevin Moore  Update MDN source and doc comments (dart-lang/web#244)
  53862f1  2024-05-22  Kevin Moore  update lints dependency (dart-lang/web#243)
  7604578  2024-05-21  Srujan Gaddam  Only emit APIs that are standards track and not experimental (dart-lang/web#239)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/45b8ce9..afd1e3c):
  afd1e3c  2024-05-23  Brian Quinlan  Remove `--fatal-infos` from `dart pub downgrade` analysis (dart-lang/web_socket_channel#367)
  cb20b71  2024-05-23  Sarah Zakarias  Add `topics` to `pubspec.yaml` (dart-lang/web_socket_channel#362)
  8514229  2024-05-22  Kevin Moore  Bump and fix lints (dart-lang/web_socket_channel#366)

webdev (https://github.com/dart-lang/webdev/compare/fc32eb6..1bed26a):
  1bed26ab  2024-05-28  Elliott Brooks  Add a reload handler along with a restart handler (dart-lang/webdev#2439)
  15028c4f  2024-05-24  Elliott Brooks  Register a restart handler directly over the VM service connection (dart-lang/webdev#2437)

Change-Id: I4e80ae77b6e74b9cd0b5524b1ba66e0f3de0a14e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368445
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 30, 2024
@iinozemtsev
Revert "[deps] rev args, async, benchmark_harness, boolean_selector, …
be24c79 
…collection, dartdoc, markdown, shelf, web, web_socket_channel, webdev"

This reverts commit 9c5085e.

Reason for revert: b/343654390

Original change's description:
> [deps] rev args, async, benchmark_harness, boolean_selector, collection, dartdoc, markdown, shelf, web, web_socket_channel, webdev
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> args (https://github.com/dart-lang/args/compare/cf90551..b3608bd):
>   b3608bd  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/args#275)
>
> async (https://github.com/dart-lang/async/compare/77a25d7..f933ddf):
>   f933ddf  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/async#275)
>
> benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/accc755..6fa42b0):
>   6fa42b0  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/benchmark_harness#106)
>
> boolean_selector (https://github.com/dart-lang/boolean_selector/compare/2cbd4a6..84467e5):
>   84467e5  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/boolean_selector#61)
>
> collection (https://github.com/dart-lang/collection/compare/4718398..fe2e800):
>   fe2e800  2024-05-28  Kevin Moore  bump lints dep and fix (dart-lang/collection#344)
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/1e1a004..ed97585):
>   ed975850  2024-05-28  Sam Rawlins  Fix flutter CI with re-internalized snippets tool (dart-lang/dartdoc#3776)
>
> markdown (https://github.com/dart-lang/markdown/compare/340c76f..c1013dc):
>   c1013dc  2024-05-28  Kevin Moore  update lints dependency (dart-lang/markdown#613)
>   7a3b8d6  2024-05-28  Sam Rawlins  Bump to 7.2.3 (dart-lang/markdown#612)
>
> shelf (https://github.com/dart-lang/shelf/compare/d9f82bf..338962c):
>   338962c  2024-05-28  Kevin Moore  update lints dependency (dart-lang/shelf#433)
>
> web (https://github.com/dart-lang/web/compare/d776645..f6f778b):
>   f6f778b  2024-05-28  Kenzie Davisson  Expose `onUnload` event stream and `ElementStream` as a public class (dart-lang/web#246)
>   e1d5148  2024-05-23  Kevin Moore  Update MDN source and doc comments (dart-lang/web#244)
>   53862f1  2024-05-22  Kevin Moore  update lints dependency (dart-lang/web#243)
>   7604578  2024-05-21  Srujan Gaddam  Only emit APIs that are standards track and not experimental (dart-lang/web#239)
>
> web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/45b8ce9..afd1e3c):
>   afd1e3c  2024-05-23  Brian Quinlan  Remove `--fatal-infos` from `dart pub downgrade` analysis (dart-lang/web_socket_channel#367)
>   cb20b71  2024-05-23  Sarah Zakarias  Add `topics` to `pubspec.yaml` (dart-lang/web_socket_channel#362)
>   8514229  2024-05-22  Kevin Moore  Bump and fix lints (dart-lang/web_socket_channel#366)
>
> webdev (https://github.com/dart-lang/webdev/compare/fc32eb6..1bed26a):
>   1bed26ab  2024-05-28  Elliott Brooks  Add a reload handler along with a restart handler (dart-lang/webdev#2439)
>   15028c4f  2024-05-24  Elliott Brooks  Register a restart handler directly over the VM service connection (dart-lang/webdev#2437)
>
> Change-Id: I4e80ae77b6e74b9cd0b5524b1ba66e0f3de0a14e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368445
> Commit-Queue: Konstantin Shcheglov <[email protected]>
> Reviewed-by: Konstantin Shcheglov <[email protected]>
> Auto-Submit: Devon Carew <[email protected]>

Change-Id: Ief02507626fe2ef4e8a92e20872a0fec37ae3b71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368800
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Auto-Submit: Ivan Inozemtsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helin24 helin24 helin24 approved these changes

Assignees
No one assigned
Labels
changelog-not-required package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @helin24