-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a script for the release steps of dwds
and webdev
#2049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Elliott, I left a couple of comments.
'../dwds', | ||
'../webdev', | ||
'../frontend_server_common', | ||
'../frontend_server_client', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add ../test_common
and all the test projects in the fixtures as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test_common
! To be honest, I've never run dart pub upgrade
from the other test packages before publishing (I'm actually not clear why this was part of the manual process, but included it since it is one of the things we did when publishing manually)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will catch CI breaks if something goes wrong with constraint resolution (CI always runs pub upgrade)
tool/release.dart
Outdated
segments.lastWhere((segment) => segment.startsWith('*')).substring(1); | ||
_logInfo('Changing DWDS pin from $currentVersion to $nextVersion'); | ||
_replaceInFile( | ||
File('../webdev/pubspec.yaml'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be'../$package/pubspec.yaml'
since we pass package as a parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Done, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds the Dart script
tool/release.dart
which automates the steps needed for releasingdwds
andwebdev
:To prepare DWDS for release:
dart run release.dart -p dwds
To prepare WebDev for release:
dart run release.dart -p webdev
To reset DWDS after a release:
dart run release.dart --reset -p dwds -v -[[dev version]]
To reset WebDev after a release:
dart run release.dart --reset -p webdev -v -[[dev version]]
Work towards #2085