Skip to content

Commit

Permalink
Defer changes in v3.3.0-wip to v4.0.0-wip
Browse files Browse the repository at this point in the history
  • Loading branch information
derekxu16 committed Dec 14, 2023
1 parent 09d0a96 commit 0174cd2
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 14 deletions.
8 changes: 3 additions & 5 deletions frontend_server_client/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
## 4.0.0-wip

- Update Dart SDK constraint to `^3.0.0`.
- Support changes in the SDK layout for Dart 3.0.
- By default, start the frontend server from the AOT snapshot shipped in the
Dart SDK.
- Throw an `ArgumentError` when `FrontendServerClient.start` is called with the
`frontendServerPath` argument omitted and the `debug` argument set to true.

## 3.3.0

- Update Dart SDK constraint to `>=3.0.0 <4.0.0`.
- Support changes in the SDK layout for Dart 3.0.
- Update `package:vm_service` constraint to `^14.0.0`.

## 3.2.0

Expand Down
16 changes: 8 additions & 8 deletions frontend_server_client/lib/src/frontend_server_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ class FrontendServerClient {
feServer = await Process.start(
Platform.resolvedExecutable,
<String>[
if (debug) '--observe',
frontendServerPath,
...commonArguments,
],
if (debug) '--observe',
frontendServerPath,
...commonArguments,
],
);
} else if (File(_feServerAotSnapshotPath).existsSync()) {
if (debug) {
Expand All @@ -123,10 +123,10 @@ class FrontendServerClient {
feServer = await Process.start(
Platform.resolvedExecutable,
<String>[
if (debug) '--observe',
_feServerAppJitSnapshotPath,
...commonArguments,
],
if (debug) '--observe',
_feServerAppJitSnapshotPath,
...commonArguments,
],
);
}
var feServerStdoutLines = StreamQueue(feServer.stdout
Expand Down
2 changes: 1 addition & 1 deletion frontend_server_client/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ dev_dependencies:
test: ^1.16.0
test_descriptor: ^2.0.0
test_process: ^2.0.0
vm_service: ^8.0.0
vm_service: ^14.0.0

0 comments on commit 0174cd2

Please sign in to comment.