Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responseHeaders extension on XMLHttpRequest #298

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Sep 2, 2024

Move this extension from package:http here, it might also be used in package:grpc.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Move this extension from `package:http` to here, it might also be used in `package:grpc`.
Copy link
Contributor

@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Ideally, a simple test would be nice so this method doesn't change accidentally! You can add a test to web/test/helpers_test.dart.

web/lib/src/helpers/extensions.dart Show resolved Hide resolved
@mosuem mosuem requested a review from srujzs September 4, 2024 12:41
@mosuem mosuem merged commit 6a8c3c5 into main Sep 4, 2024
17 checks passed
@mosuem mosuem deleted the mosuem-patch-1 branch September 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants