Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross-origin window and location wrappers #291
Add cross-origin window and location wrappers #291
Changes from all commits
1e17c5a
fd199ec
c4f1f8f
4351aa3
56d78b2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional) I wonder if it would be worth to also add test coverage of the unwrapped behavior? That is, something that verifies that cross-origin windows/locations fail if you tried to access them directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it'd be useful to verify.
In the process of adding this, however, I noticed
package:test
doesn't quite work as expected. Running a known same-origin policy violation e.g. accessingnavigator
on an opened window from a different origin only fails if you--pause-after-load
and single-step through the test. Without that, opened windows' origins appears to be the same as the opening window's origin (localhost
). I know there's some setup to load these tests in an iframe to run them, but I can't tell how it results in the above behavior. The current test passes regardless of if you single-step, so for now, I put a TODO.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both the test runner and
package:test
have this issue. After a good amount of debugging, I can't tell how to enable same-origin policy. Filed dart-lang/test#2282 for now and single-stepped to verify that there are no cross-origin issues with the current test.