-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error for empty groups #2012
Draft
natebosch
wants to merge
16
commits into
master
Choose a base branch
from
disallow-empty-groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on May 10, 2023
-
Closes #1961 After declaring a group check for declared tests, if there were none add a synthetic test that fails with an error about the empty group.
Configuration menu - View commit details
-
Copy full SHA for 96ed242 - Browse repository at this point
Copy the full SHA 96ed242View commit details
Commits on May 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b8aabbb - Browse repository at this point
Copy the full SHA b8aabbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3806a9f - Browse repository at this point
Copy the full SHA 3806a9fView commit details
Commits on May 13, 2023
-
Don't report for empty top level group
The output already has special behavior for when there are no tests at all, and the output is less clear when it's the root group which is empty since the root group has no name. Also refactor duplicate name tests to have different file content when testing identical group names to avoid empty groups in any case.
Configuration menu - View commit details
-
Copy full SHA for 999cc83 - Browse repository at this point
Copy the full SHA 999cc83View commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12b2674 - Browse repository at this point
Copy the full SHA 12b2674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97a8a5b - Browse repository at this point
Copy the full SHA 97a8a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70f8a33 - Browse repository at this point
Copy the full SHA 70f8a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d9cacc - Browse repository at this point
Copy the full SHA 8d9caccView commit details
Commits on Oct 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa89895 - Browse repository at this point
Copy the full SHA fa89895View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf113bd - Browse repository at this point
Copy the full SHA bf113bdView commit details
Commits on Oct 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4fbfe5e - Browse repository at this point
Copy the full SHA 4fbfe5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcf9ed9 - Browse repository at this point
Copy the full SHA fcf9ed9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63a7f39 - Browse repository at this point
Copy the full SHA 63a7f39View commit details
Commits on Oct 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 421e8dc - Browse repository at this point
Copy the full SHA 421e8dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9ecaac - Browse repository at this point
Copy the full SHA e9ecaacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13df7e3 - Browse repository at this point
Copy the full SHA 13df7e3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.