Nicer failures when an annotation is not resolvable #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kevmoo
approved these changes
Jul 5, 2017
lib/src/type_checker.dart
Outdated
| if (element.metadata.isEmpty) { | ||
| return null; | ||
| } | ||
| final results = annotationsOfExact(element); |
There was a problem hiding this comment.
or .single(orElse: () => null – or something like that
There was a problem hiding this comment.
Would be results.firstWhere((_) => true, orElse: () => null); IMO what is already in this PR is more readable.
natebosch
approved these changes
Jul 5, 2017
matanlurey
force-pushed
the
nicer-analysis-failures
branch
from
10ba7c2 to
99f35a0
Compare
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…_gen#201) * Add annotationsOfExact. * Add type checks. * Update CHANGELOG.
mosuem
pushed a commit
to dart-lang/build
that referenced
this pull request
Dec 10, 2024
…_gen#201) * Add annotationsOfExact. * Add type checks. * Update CHANGELOG.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #200.
Closes #198.