Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS annotation requirement now that #54801 is Fixed #5632

Closed
1 task
Cat-sushi opened this issue Mar 8, 2024 · 2 comments
Closed
1 task

Update JS annotation requirement now that #54801 is Fixed #5632

Cat-sushi opened this issue Mar 8, 2024 · 2 comments
Assignees
@parlough
Labels
dev.interop Relates to use of native code as part of your Dart app e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes st.triage.ltw Indicates Lead Tech Writer has triaged target.web Target apps on the web platform

Comments

@Cat-sushi
Copy link

Page URL

https://dart.dev/interop/js-interop/usage/

Page source

https://github.com/dart-lang/site-www/tree/main/./src/content/interop/js-interop/usage.md

Describe the problem

Following warning should be deleted, because the bug is fixed and Flutter 3.19.3 is released.

There's a bug that currently requires object literal constructors to have an @JS annotation on the library. See #54801 for more details.

Expected fix

remove the note.

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on dart.dev.
@Cat-sushi Cat-sushi added the from.page-issue Reported in a reader-filed concern label Mar 8, 2024
@parlough parlough added p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes e0-minutes Can complete in < 60 minutes of normal, not dedicated, work target.web Target apps on the web platform dev.interop Relates to use of native code as part of your Dart app labels Mar 10, 2024
@parlough parlough changed the title [PAGE ISSUE]: 'Usage' #54801 is Fixed Update JS annotation requirement now that #54801 is Fixed Mar 10, 2024
@parlough
Copy link
Member

parlough commented Mar 10, 2024 •
edited
Loading

Good catch! Thanks for calling this out.

I think it's best to keep the note there for a bit, for those using interop on earlier releases, as it doesn't hurt, but we can perhaps adjust the note for now? #5638

@parlough parlough mentioned this issue Mar 10, 2024
Merged
parlough added a commit that referenced this issue Mar 11, 2024
@parlough
Update 54801 issue note (#5638)
6e824b9 
Update the note now that a fix has been released.

Contributes to #5632
@atsansone atsansone added the st.triage.ltw Indicates Lead Tech Writer has triaged label Mar 19, 2024
@atsansone atsansone self-assigned this Mar 19, 2024
atsansone pushed a commit to atsansone/site-www that referenced this issue Mar 22, 2024
@parlough @atsansone
Update 54801 issue note (dart-lang#5638)
694b312 
Update the note now that a fix has been released.

Contributes to dart-lang#5632
@parlough
Copy link
Member

I'm going to close this as resolved by #5638, our normal version note triage will catch this in the future alongside future releases. Thanks again!

@parlough parlough self-assigned this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parlough parlough

Labels
dev.interop Relates to use of native code as part of your Dart app e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.page-issue Reported in a reader-filed concern p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes st.triage.ltw Indicates Lead Tech Writer has triaged target.web Target apps on the web platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsansone @Cat-sushi @parlough