Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to Response for including file and file_not_found to be identified by other shelf Middleware. #436

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkgs/shelf_static/lib/src/static_handler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ Handler createFileHandler(String path, {String? url, String? contentType}) {

return (request) {
if (request.url.path != url) {
var fileNotFound = File(p.join(parent.path, request.url.path));
var fileNotFound =
File(p.joinAll([parent.path, ...p.split(request.url.path)]));
gmpassos marked this conversation as resolved.
Show resolved Hide resolved
return Response.notFound(
'Not Found',
context: buildResponseContext(fileNotFound: fileNotFound),
Expand Down