Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Building-Dart-SDK-for-ARM-or-RISC-V.md #56983

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Haui1112
Copy link

@Haui1112 Haui1112 commented Oct 29, 2024

Make it clear that this depends on the regular build instructions.

  • The build instructions for arm and riscv are not clear enough, leading people into errors. This should prevent it.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

Make it clear that this depends on the regular build instructions.
Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@devoncarew
Copy link
Member

Thanks for the contribution! Can you sign the CLA (see instructions at https://github.com/dart-lang/sdk/pull/56983/checks?check_run_id=32214371666)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants