-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart2js] Fix compatiblity with Node.js 21 #53796
Conversation
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/330987 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
Thanks so much for the contribution, added @rakudrama on the gerrit CL for review. |
There are a few other places in this repo where generated codes need to be updated. I'm not sure what's the right way to get each of those updated. Please advice. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
Can you explain where these places are, e.g. an example of some generated code, or a location in the repo? |
@rakudrama |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
@rakudrama The latest commit should address your concerns in review. Other generated codes need updates are all tests, so they can probably be updated later as long as the sdk repo itself is not being tested with node 21. As for how this changed tested, I'm testing it with dart-sass, which is what most of the users are complaining about. I first ran dart-sass' test with node 21 and official dart-sdk 3.1.4 and confirm it fails. Then I build a custom 3.1.4 with this patch applied on top, and ran dart-sass' test again, everything seems to be fine. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
Looks like tests in |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
@rakudrama I updated the dump_info with newly built sdk and now the failed test passes for me locally. Would you please retry it on CI? |
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
1 similar comment
https://dart-review.googlesource.com/c/sdk/+/330987 has been updated with the latest commits from this pull request. |
@rakudrama Sorry that I'm very not familiar with gerrit and its flow. It looks like the tests have all passed but gerrit dismissed a previous vote because I merged latest main into this feature branch after the vote. I'm not sure what action is needed from here. Please let me know if anything is needed. |
I think it looks good. Thanks for your help and patience! |
Closes #53796 GitOrigin-RevId: caeeb52 Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/330987 Cherry-pick-request: TBA Change-Id: I459da4b14b29bccca5be2d053d472770f20b04a8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331323 Reviewed-by: Stephen Adams <[email protected]>
This PR fixes #53784.