Type checking of named arguments is wrong.

[peter-ahe-google]

$ dartc fisk.dart
fisk.dart:4: int is not assignable to String
     3: main() {
     4: fisk(i: 1);
$ cat fisk.dart
fisk([String string, int i]) {}

main() {
  fisk(i: 1);
}

[peter-ahe-google]

The implementation for type checking named arguments is bogus. This patch removes the symptom, but doesn't correctly implement type checking of named arguments.

--- a/dart/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/dart/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -532,12 +532,8 @­@ public class TypeAnalyzer implements DartCompilationPhase {
       Map<String, Type> namedParameterTypes = ftype.getNamedParameterTypes();
       Iterator<Type> named = namedParameterTypes.values().iterator();
       while (named.hasNext() && argumentTypes.hasNext()) {

•    checkAssignable(argumentNodes.get(argumentCount), named.next(), argumentTypes.next());
  

•    argumentCount++;
  

•  }
  

•  while (ftype.hasRest() && argumentTypes.hasNext()) {
  

•    checkAssignable(argumentNodes.get(argumentCount), ftype.getRest(), argumentTypes.next());
  

•    argumentCount++;
  

•    // Cannot deal with named arguments.
  

•    return ftype.getReturnType();
  

         }
         while (argumentTypes.hasNext()) {
           argumentTypes.next();

[DartBot]

This comment was originally written by [email protected]

---

Frog handles this just fine - this is a dartc issue.

---

Removed Area-Frog label.
Added Area-Compiler label.

[scheglov]

Set owner to @scheglov.

[scheglov]

https://chromiumcodereview.appspot.com/9270016

[scheglov]

Added Started label.

[scheglov]

Added Fixed label.