Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#resource is not supported by the vm #732

Closed
vsmenon opened this issue Dec 7, 2011 · 3 comments
Closed

#resource is not supported by the vm #732

vsmenon opened this issue Dec 7, 2011 · 3 comments
Assignees
@iposva-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@vsmenon
Copy link
Member

vsmenon commented Dec 7, 2011

Certain samples had been using #resource as mentioned in the spec. Right now, this gives a parse error in the VM. I've removed them from the samples for now.

We'd like to put them back - the editor is able to take advantage of them.
@danrubel
Copy link

It would be great if both Dartium and the VM would simply ignore #resource directives.

@iposva-google
Copy link
Contributor

Set owner to @iposva-google.

@iposva-google
Copy link
Contributor

Fixed with https://code.google.com/p/dart/source/detail?r=4493

Added Fixed label.

@vsmenon vsmenon added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Feb 23, 2012
@iposva-google iposva-google mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Sep 22, 2022
@osa1
259546: Roll Dart Protobuf Support from cd0ff30759d8 to 1d175bef6043
2c612c1 
Re-submitting 259546 with updated golden tests.

https://dart.googlesource.com/protobuf/+log/cd0ff30759d8..1d175bef6043

2022-09-16 [email protected] Fix $_getMap return value when mutability when message is read-only (#754)
2022-09-16 [email protected] Eliminate more type casts when targeting JS (#732)
2022-09-15 [email protected] Make subBuilder args of BuilderInfo message methods required (#753)

Change-Id: I0447b0ba277251e49dc373941599039e0e041019
Tested: CL updates test golden expectations
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259740
Reviewed-by: Alexander Markov <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Ömer Ağacan <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vsmenon @danrubel @iposva-google