Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" into stable #55714

Closed
mkustermann opened this issue May 14, 2024 · 4 comments
Closed

[CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" into stable #55714

mkustermann opened this issue May 14, 2024 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@mkustermann
Copy link
Member

Commit(s) to merge

54031e2

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/366300

Issue Description

Without this fix some apps run into crashes of the dart2wasm compiler, see #55529

What is the fix

The fix is to ensure synthetic functions created by CFE have default values for parameters where needed.

Why cherry-pick

We don't want customers to run into dart2wasm crashes in next stable branch.

Risk

If we run all CI tests on cherry-pick requests then risk is low.

Issue link(s)

#55529

Extra Info

No response
@mkustermann mkustermann added the cherry-pick-review Issue that need cherry pick triage to approve label May 14, 2024
@mkustermann mkustermann changed the title [CP] <title> [CP] Cherry-Pick "[cfe] Ensure default values in synthesized function nodes" into stable May 14, 2024
@mkustermann
Copy link
Member Author

This was CPed on beta branch (#55656) - but the stable branch was cut without it. So we should make a CP on stable.

@mkustermann mkustermann mentioned this issue May 14, 2024
Closed
@mit-mit
Copy link
Member

mit-mit commented May 14, 2024

sgtm

@itsjustkevin
Copy link
Contributor

Approval was already gained on the beta cherry-pick. Approving this change to stable.

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label May 14, 2024
copybara-service bot pushed a commit that referenced this issue May 15, 2024
@mkustermann
[stable] [cfe] Ensure default values in synthesized function nodes
3ce1c7c 
Closes #55529

Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/364325
Cherry-pick-request: #55714
Change-Id: If532820d53680a754c9e79a5a66367b1d44c6505
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366300
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Slava Egorov <[email protected]>
@mkustermann
Copy link
Member Author

@itsjustkevin the CP landed on stable.

@lrhn lrhn added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vsmenon @lrhn @mkustermann @itsjustkevin @mit-mit @athomas