Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deprecating an export of a symbol #48807

Closed
natebosch opened this issue Apr 14, 2022 · 3 comments
Closed

Add support for deprecating an export of a symbol #48807

natebosch opened this issue Apr 14, 2022 · 3 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-duplicate Closed in favor of an existing report

Comments

@natebosch
Copy link
Member

In order to move definitions between libraries we sometimes use an incremental state where you can use either the old or the new import. The class/method may not be deprecated entirely, but we'd want to push towards getting it from the new import. If something is available through two imports and only one is deprecated there shouldn't be a diagnostic.

We've discussed this recently, but I couldn't find an existing issue so filing one now to gather discussion.

@natebosch natebosch added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Apr 14, 2022
@natebosch
Copy link
Member Author

This is likely a blocker for a feature like #44892 - we'd need the deprecation to trigger a diagnostic.

I think the unused imports diagnostic is already smart enough to understand when all the symbols from one import are also available from another. If that's the case we'd want to make sure it's not suggesting the deprecated import paths.

@lrhn
Copy link
Member

lrhn commented Apr 14, 2022

See also: #23067

@natebosch natebosch added the closed-duplicate Closed in favor of an existing report label Apr 14, 2022
@natebosch
Copy link
Member Author

Ah, I thought I had recalled another issue but didn't search long enough. Closing as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

2 participants