Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_data.yaml import element #44892

Open
TimWhiting opened this issue Feb 9, 2021 · 1 comment
Open

fix_data.yaml import element #44892

TimWhiting opened this issue Feb 9, 2021 · 1 comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. dart-cli-fix P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@TimWhiting
Copy link

I'm not sure if it is common knowledge but I've been seeing commits in dart-lang/sdk and flutter/flutter about this fix_data.yaml format for adding fixes. Just took a closer look at making one for my own package / packages that I contribute to which are going through some breaking changes / deprecations.

This wouldn't be a frequent fix, but in some cases packages have non-standard imports: e.g. (package:riverpod/all.dart vs package:riverpod/riverpod.dart). Currently the riverpod package is deprecating the all.dart import in favor of exporting everything through riverpod.dart. However, I didn't find a way to have the element for the fix be an import. Would this be possible to support?

@bwilkerson
Copy link
Member

Thanks for your interest!

The feature you found is one that is still under development and not yet supported for general use. We hope that it will prove useful both to users and to package developers, and that we can make it more generally available at a future date. In the meantime, we can’t make any guarantees related to breaking changes, such as possible changes to the file format.

As for the technical issue, yes, it’s likely that we could support a “move library” change. We don’t currently have the resources to implement this feature, but we’re not opposed to doing so in the future if this becomes a publicly available feature.

And, of course, contributions are always welcome. If you’re interested in implementing such an enhancement, I’d be happy to work with you to design the support and answer any questions you have about how to implement it.

@mit-mit mit-mit added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Feb 24, 2021
@devoncarew devoncarew added dart-cli-fix P2 A bug or feature request we're likely to work on labels Feb 24, 2021
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. dart-cli-fix P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants