dartc should ignore leading newline in multi-line strings, like VM

[DartBot]

This issue was originally filed by [email protected]

---

main() {
  var str = """
hello
""";
  Expect.equals("h", str[0], "str should begin with h (no leading newline)");
}

Background in issue #240: <http://code.google.com/p/dart/issues/detail?id=240>.

[DartBot]

This comment was originally written by [email protected]

---

Added Area-Compiler, Triaged labels.

[scheglov]

Set owner to @scheglov.

[scheglov]

Yes, but what is NEWLINE?
According to spec right now:

NEWLINE:
\n' | \r'
;

  So, NEWLINE is '\n' or '\r'

  However 03_3_Strings_A03_t01.dart and all co19/src/LangGuideTest/03_Values tests use Windows style newline "\r\n".
  So, these tests are invalid, or spec should state that '\r\n' is also valid NEWLINE.

  JFYI, DartC right now skips leading '\n' (and only it).
  I can easily add '\r', but I can not add '\r\n' because it is not in spec.

[DartBot]

This comment was originally written by [email protected]

---

Not an issue for dartc anymore, but possibly a co19 or spec issue.

---

Removed the owner.
Removed Area-Compiler label.
Added New label.

[anders-sandholm]

Peter/Gilad, not sure if this is still an issue and if so whether it is a co19 or spec issue.

---

cc @peter-ahe-google.
Added Area-Language, Triaged labels.

[whesse]

I don't see a definition of NEWLINE in the spec any more. I think it is important that we explain exactly what is done with newline sequences in all situations, and that \r\n and \n are accepted as newlines. Is there ever a case in which we want to emit a \r\n without writing it explicitly? If there was a text-mode file write for Windows, we might.

[peter-ahe-google]

If you search for NEWLINE, you get this hit on page 43:

NEWLINE:
\n| \r
;

This definition is not good enough. I think we should just adopt the convention from XML http://www.w3.org/TR/REC-xml/#sec-line-ends

This means that all newlines are normalized to \n. Notice that it is not good enough to simply say that \r is translated to \n.

---

Set owner to @gbracha.
Added Accepted label.

[anders-sandholm]

Added this to the M1 milestone.

[gbracha]

This is so close to 240 that I'm merging them.

---

Added Duplicate label.
Marked as being merged into #240.