dartc fails ImplicitThisTest/none #375
Assignees
Comments
|
This comment was originally written by [email protected] http://codereview.chromium.org/8728001/ Set owner to @scheglov. |
|
This comment was originally written by [email protected] We are making changes to the compiler and following some of the notes in the non-normative text in section 7.1.1. There must be some reason it hasn't firmed up by now - please let us know if this change is premature. cc @gbracha. |
|
Issue #362 has been merged into this issue. |
|
Now we produce all warnings, recommended by spec for abstract/incomplete classes. Added Fixed label. |
dart-bot
pushed a commit
that referenced
this issue
Jun 12, 2019
2019-06-11 [email protected] More fixes to cast response to Stream<List<int>> (#385) 2019-06-11 [email protected] Pass Uint8List to Datagram (#382) 2019-06-11 [email protected] Cast HttpRequest and HttpClientResponse streams to List<int> (#384) 2019-06-10 [email protected] Fixes #364. Change expected result to null for default values of clientMaxWindowBits and serverMaxWindowBits 2019-06-07 [email protected] Fixes #380. Added tests for logical and bitwise operations via type aliases 2019-06-07 [email protected] Additional fix for #373. Code style improved and more strict pattern checking 2019-06-06 [email protected] Fix for #380. Added tests for type aliases for built-in types. Test string concatenation and arithmetic operations 2019-06-05 [email protected] Fixes #380. Added tests for type aliases for built-in types initialization 2019-06-05 [email protected] Fixes #373. Expect reasonable file mode on Unix 2019-06-04 [email protected] Fixes #379. Numerous fixes for io/Process tests 2019-06-04 [email protected] Fixes #378. Use Platform.resolvedExecutable instead of 'dart' command 2019-06-04 [email protected] Fixed Issue #375: it's possible that IPv6 loopback does not exist. 2019-06-04 [email protected] Fixed Issue #236: host.host can be either "localhost" or Platform.localHostname. 2019-06-04 [email protected] Issue #370, instantiate-to-bounds: added static tests for non-function type aliases. 2019-06-04 [email protected] Fix for #377. Use correct network interface type name (IPvX) 2019-06-04 [email protected] Fixes #374. Change pattern for error messages 2019-06-04 [email protected] Issue #370, instantiate-to-bounds: added dynamic tests for non-function type aliases. 2019-06-04 [email protected] Fix for #372. Expect.fail() on timeout added 2019-06-04 [email protected] Fixes #371. Remove excessive asyncStart() 2019-06-03 [email protected] Issue #147, test super bounded types: added tests for non-function type aliases. 2019-05-30 [email protected] Fixes #369. Use correct type arguments to avoid errors 2019-05-30 [email protected] Fixes #368. Don't try to bind system port 2019-05-30 [email protected] Fixes #367. Remove excessive asyncStart() 2019-05-30 [email protected] Fixes #366. Change expected result to SocketException [email protected] Change-Id: I137689755907b3333e597d7d210db2b4d37d70d0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105641 Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: William Hesse <[email protected]>
This was referenced Oct 29, 2020
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a pretty nasty test that also uses the abstract keyword on classes. This is in the spec but as far as I know not yet implemented by any Dart VM or compiler.
ImplicitThisTest/none: Fail
Please notice that the current implementation for detecting abstract classes in dartc is wrong, this is because the specification has changed since I implemented it in dartc. Fortunately, it is much simpler now.
I have an old patch to dartc that I never submitted for detecting unimplemented getters and setters. Let me know if there is interest in looking at this patch and I can upload it to the code review server.
The text was updated successfully, but these errors were encountered: