Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dummy_compiler_test is erroneous #27744

Closed
johnniwinther opened this issue Nov 3, 2016 · 2 comments
Closed

dummy_compiler_test is erroneous #27744

johnniwinther opened this issue Nov 3, 2016 · 2 comments
Assignees
@johnniwinther
Labels
web-dart2js

Comments

@johnniwinther
Copy link
Member

Due to import of 'package:kernel' in dart2js, utils/dummy_compiler_test and utils/recursive_import_test are trying to compile a program with compile-time errors.

This might be the underlying reason for why Dartium now fails on these.
@johnniwinther johnniwinther self-assigned this Nov 3, 2016
@johnniwinther
Copy link
Member Author

This might be related to #27441

@sigmundch
Copy link
Member

it seems that we are importing 'package:kernel/kernel.dart' in one place, but we might be able to import directly 'package:kernel/ast.dart' instead and get rid of the transitive link to dart:io.

I have a fix out for review here: https://codereview.chromium.org/2485093003/

sigmundch added a commit that referenced this issue Nov 8, 2016
@sigmundch
dart2js: depend directly on kernel/ast to avoid indirect dependency o…
ce758e7 
…n dart:io

BUG= #27744
[email protected]

Review URL: https://codereview.chromium.org/2485093003 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigmundch @johnniwinther