Dart Editor takes too long building workspace after save

[DartBot]

This issue was originally filed by @sethladd

---

A 50k line Dart file takes too long to "rebuild" after a save/change in the editor. This process blocks the user, eventually convincing them that saving is too cumbersome of an operation.

The Editor should transparently, in the background, rebuild and reanalyze the files as the developer types, without interrupting the developer.

See https://plus.google.com/107016091651015882408/posts/FVWEKMN32xG

[DartBot]

This comment was originally written by @ltackmann

---

Small correction, its not a 50k dart file but a 50k dart app ;).

Also the problem is apparent in a much smaller code base already around 5k the delays starts to get bad and above 10k its intolerable.

 

[DartBot]

This comment was originally written by [email protected]

---

One of my projects (Buckshot: https://github.com/prujohn/Buckshot) is 27k lines, including demos, etc.
My machine, which is Win7-64, 32gb RAM, 6-core.

During re-factoring, particularly if I save a file that breaks code in many other files, the Editor will slow to a crawl. The workspace build will sometimes hang, leaving me unable to close the editor, and in some cases, I'll have to reboot the machine in order to clear it.

In one instance, the editor would hang on build, whenever I loaded the project, even after clearing the workspace directory and reloading. I had to go in and manipulate files outside the editor until it would load successfully.

[DartBot]

This comment was originally written by [email protected]

---

I've got buckshot up in a copy of the Editor, build 5549. Can you give me an example of a pathological edit?

[DartBot]

This comment was originally written by [email protected]

---

The steps below aren't exactly what I did the other day to get the Editor to hang, but it seems to work.

1. In lib/system/FrameworkElement.dart, place something breaking at line 129, like an incomplete function: 'someFunc(foo, bar) =>'. Save the project.
2. In the editor, RENAME the lib/system directory to lib/sys.
3. In lib/Buckshot.dart, begin to fix the file paths one file at a time (this is important), and save after editing each line. Try to overlap a save with the workspace build/indexing process.

After doing this a few times, you'll notice the editor UI start to lag in responsiveness. What I am trying to re-create with #­3 is the scenario where I am coding and saving files faster than the editor can keep up, which is frequently in project as large as Buckshot.

1. Now, repeat step #­3 a few more times, and then CANCEL the workspace build while it is still in progress. This put the editor into a hung state for about 10 minutes on my machine and resulted in an error dialog (attached).

Hope this helps a bit. This happens to me about once/day.

---

Attachment:
dart_editor_error_dialog.png (23.81 KB)

[DartBot]

This comment was originally written by [email protected]

---

Sorry, forgot to mention: I'm on build 5807.

[DartBot]

This comment was originally written by [email protected]

---

Removed Priority-Medium label.
Added Priority-High, Area-Editor, Triaged labels.

[clayberg]

Set owner to @danrubel.

[danrubel]

Issue #2895 has been merged into this issue.

[clayberg]

Added this to the M1 milestone.

[keertip]

Added Fixed label.