Skip to content

Commit

Permalink
Retire 2.19 experiment.
Browse files Browse the repository at this point in the history
Tested: No tests. Removing functionality, all existing tests running is a success.
Change-Id: I25eb84347e1d133d465671223f4d3b037116c5e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294241
Reviewed-by: Liam Appelbe <[email protected]>
Auto-Submit: Lasse Nielsen <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Kevin Chisholm <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
Commit-Queue: Lasse Nielsen <[email protected]>
  • Loading branch information
lrhn authored and Commit Queue committed Apr 12, 2023
1 parent 55ec454 commit 80de916
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ enum ExperimentalFlag {
unnamedLibraries(
name: 'unnamed-libraries',
isEnabledByDefault: true,
isExpired: false,
isExpired: true,
experimentEnabledVersion: const Version(2, 19),
experimentReleasedVersion: const Version(2, 19)),

Expand Down
2 changes: 1 addition & 1 deletion pkg/analyzer/lib/src/dart/analysis/experiments.g.dart
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ class IsExpired {
static const bool triple_shift = true;

/// Expiration status of the experiment "unnamed-libraries"
static const bool unnamed_libraries = false;
static const bool unnamed_libraries = true;

/// Expiration status of the experiment "value-class"
static const bool value_class = false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class ExperimentalFlag {
static const ExperimentalFlag unnamedLibraries = const ExperimentalFlag(
name: 'unnamed-libraries',
isEnabledByDefault: true,
isExpired: false,
isExpired: true,
enabledVersion: const Version(2, 19),
experimentEnabledVersion: const Version(2, 19),
experimentReleasedVersion: const Version(2, 19));
Expand Down
2 changes: 1 addition & 1 deletion runtime/vm/experimental_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ namespace dart {

bool GetExperimentalFeatureDefault(ExperimentalFeature feature) {
constexpr bool kFeatureValues[] = {
true, true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true, true,
true, true, true, true, true, true, true, true,
};
ASSERT(static_cast<size_t>(feature) < ARRAY_SIZE(kFeatureValues));
return kFeatureValues[static_cast<int>(feature)];
Expand Down
1 change: 1 addition & 0 deletions tools/experimental_features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ features:
unnamed-libraries:
help: "Unnamed libraries"
enabledIn: '2.19.0'
expired: true
validation: |
library;
void main() => print('feature enabled');
Expand Down

0 comments on commit 80de916

Please sign in to comment.