Skip to content

Commit

Permalink
Remove unused type parameter
Browse files Browse the repository at this point in the history
This CL removes an unused type parameter from a test in _macros.
The type parameter gave rise to a warning from the lint
`avoid_types_as_parameter_names` because it had the same name as a
type in scope (`Declaration`).

The type variable could also have been renamed, but it seems very unlikely that any other part of the system will break because the type parameter has been removed: The function is declared in a test, and nothing in the test depends on that type parameter in any way.

See also dart-lang/linter#5066 for details.

Change-Id: Ibc42c4a758f70564c9fe12f3bf2bfbb72e63e97d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/383600
Reviewed-by: Jake Macdonald <[email protected]>
  • Loading branch information
eernstg committed Sep 4, 2024
1 parent 309ab9c commit 410e9a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/_macros/test/executor/serialization_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ void expectSerializationEquality<T extends Serializable>(T serializable,

/// Deserializes [serialized] in its own remote instance cache and sends it
/// back.
Object? roundTrip<Declaration>(Object? serialized, int zoneId) {
Object? roundTrip(Object? serialized, int zoneId) {
return withRemoteInstanceZone(zoneId, () {
var deserializer = deserializerFactory(serialized);
var instance = RemoteInstance.deserialize(deserializer) as Serializable;
Expand Down

0 comments on commit 410e9a8

Please sign in to comment.