Skip to content

Commit

Permalink
[beta] [vm/debugger] Use safepoint-safe RwLock for breakpoint locatio…
Browse files Browse the repository at this point in the history 
…ns locks and Ensure setting breakpoints is lock-safe.

Acquire reload opreation scope when deoptimizing the world to ensure locks can be acquired for compilation.
Set up scope for operations that can be run while the world is deoptimized and stopped to avoid races.
Ensure code stays unoptizimed when single stepping, prevent other isolates to reoptimize it.

Fixes:
#54650
flutter/flutter#140878

TEST=DartAPI_BreakpointLockRace and DeoptimizeFramesWhenSettingBreakpoint

Bug: #54650 and flutter/flutter#140878
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/347420 and https://dart-review.googlesource.com/c/sdk/+/345743
Cherry-pick-request: #54699
Change-Id: Ia4bc883121dac978fbb76027906a810000ef1138
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/347760
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>
  • Loading branch information
@a-siva
a-siva authored and Commit Queue committed Jan 23, 2024
1 parent 42b177d commit 243d2e0
Show file tree
Hide file tree
Showing 6 changed files with 357 additions and 62 deletions.
Loading

0 comments on commit 243d2e0

Please sign in to comment.