Use styles from site-shared/dash_design #8280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isoos
commented
Nov 13, 2024
isoos
commented
- Updated the variable tests to also use the dash_design files.
- I've commented out the two colors that this replaces for now. I'm going to remove them with a follow-up PR when we have more colors in the shared style sheet that we import.
- No effective color change for us.
sigurdm
approved these changes
Nov 14, 2024
pkg/web_css/lib/src/_variables.scss
Outdated
| --pub-color-white: #ffffff; | ||
| --pub-color-snowWhite: #fafafa; // slight deviation from official snow-white (fffafa) | ||
| --pub-color-smokeWhite: #f5f5f7; // slight deviation from official white-smoke (f5f5f5) | ||
| --pub-color-bubblesBlue: #e7f8ff; // slight deviation from official bubbles-blue (e7feff) | ||
| --pub-color-gunpowderGray: #4a4a4a; // hsl(0, 0%, 29%); | ||
| // --pub-color-gunpowderGray: #4a4a4a; // hsl(0, 0%, 29%); |
There was a problem hiding this comment.
Should this just be deleted?
There was a problem hiding this comment.
I'd rather keep this for a short while, until we have a better consolidated view on how the naming + shared naming will work. But at the same time I can also just delete it.
There was a problem hiding this comment.
As you prefer - just note that the usual policy is to not leave commented out code.
You can always find it in git history.
sigurdm
reviewed
Nov 14, 2024
pkg/web_css/lib/src/_variables.scss
Outdated
| --pub-color-darkGunmetal: #1f262a; // close to #1d2026 | ||
| --pub-color-shadowBlack: #373737; | ||
| --pub-color-anchorBlack: #41424c; | ||
| --pub-color-nipponUltraBlue: #23607f; | ||
| --pub-color-gainsboro: #dcdcdc; | ||
| // --pub-color-gainsboro: #dcdcdc; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.