Skip to content

Commit

Permalink
Fix exported API bucket check. (#8272)
Browse files Browse the repository at this point in the history
  • Loading branch information
isoos authored Nov 11, 2024
1 parent 290625e commit 4d35a52
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/lib/shared/configuration.dart
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ final class Configuration {
publicPackagesBucketName!,
searchSnapshotBucketName!,
taskResultBucketName!,
exportedApiBucketName!,
if (exportedApiBucketName != null) exportedApiBucketName!,
]);

late final isProduction = projectId == 'dartlang-pub';
Expand Down
3 changes: 3 additions & 0 deletions app/test/shared/configuration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ void main() {
if (config.isProduction) {
expect(rateLimits, hasLength(greaterThan(10)));
}

// expect bucket names are non-null
expect(config.allBucketNames, isNotEmpty);
}
});
}

0 comments on commit 4d35a52

Please sign in to comment.