Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSDictionary.objectForKey_ at head does not allow a null return #1701

Closed
brianquinlan opened this issue Nov 5, 2024 · 2 comments · Fixed by #1718
Closed

NSDictionary.objectForKey_ at head does not allow a null return #1701

brianquinlan opened this issue Nov 5, 2024 · 2 comments · Fixed by #1718
Assignees
@liamappelbe
Labels
package:objective_c
Milestone
ffigen 16.0.0 (20...

Comments

@brianquinlan
Copy link
Contributor

brianquinlan commented Nov 5, 2024 •
edited
Loading

native/pkgs/objective_c/lib/src/objective_c_bindings_generated.dart

Line 2421 in a3749d2

objc.ObjCObjectBase objectForKey_(objc.ObjCObjectBase aKey) {

But 3.0 does:
https://pub.dev/documentation/objective_c/latest/objective_c/NSDictionary/objectForKey_.html

(the 3.0 version is correct)
@brianquinlan brianquinlan changed the title NSDictionary.objectForKey_ at head does all a null return NSDictionary.objectForKey_ at head does allow a null return Nov 5, 2024
@brianquinlan brianquinlan changed the title NSDictionary.objectForKey_ at head does allow a null return NSDictionary.objectForKey_ at head does not allow a null return Nov 5, 2024
@liamappelbe
Copy link
Contributor

We mess around with the nullabilty of certain methods to work around some inheritance issues. The visitor refactor might have introduced bugs in that logic.

@liamappelbe liamappelbe added this to the ffigen 16.0.0 milestone Nov 5, 2024
@liamappelbe
Copy link
Contributor

liamappelbe commented Nov 13, 2024 •
edited
Loading

Culprit: #1681 Actually that PR just exposed an existing bug.

liamappelbe added a commit that referenced this issue Nov 13, 2024
@liamappelbe
Fix #1701
05ebff0
@liamappelbe liamappelbe mentioned this issue Nov 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in ObjC/Swift interop Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liamappelbe liamappelbe

Labels
package:objective_c
Projects
ObjC/Swift interop
Status: Done
Milestone
ffigen 16.0.0 (2024 Q4)
Development

Successfully merging a pull request may close this issue.

[ffigen] Fix nullable typealias bug dart-lang/native
2 participants
@liamappelbe @brianquinlan