Ignore test helpers.

pkgs/leak_tracker/lib/src/leak_tracking/primitives/_test_helper_detector.dart

@@ -1,4 +1,4 @@
-// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
@@ -27,8 +27,16 @@ final _startFrame = RegExp(
   r')',
 );
 
-bool isCreatedByTestHelper(String trace, List<RegExp> exceptions) {
-  final frames = trace.split('\n');
+/// If true, leaking objects created by test helpers will be ignored.
+///
+/// Frames, that match [exceptions] will be ignored.
+///
+/// See details in doc for `LeakTesting.createdByTestHelpers`.
+bool isCreatedByTestHelper(
+  String objectCreationTrace,
+  List<RegExp> exceptions,
+) {
+  final frames = objectCreationTrace.split('\n');
   for (final frame in frames) {
     if (_startFrame.hasMatch(frame)) {
       return false;

pkgs/leak_tracker/lib/src/leak_tracking/primitives/model.dart

@@ -141,14 +141,14 @@ class IgnoredLeaks {
   /// If true, leaking objects created by test helpers will be ignored.
   ///
   /// An object counts as created by a test helper if the stack trace of
-  /// start of leak tracking contains a frame, loactaed after the test body
-  /// frame, thet points to the folder `test` or the package `flutter_test`,
+  /// start of leak tracking contains a frame, located after the test body
+  /// frame, that points to the folder `test` or the package `flutter_test`,
   /// except:
   /// * methods intended to be called from test body like `runAsunc` or `pump`
   /// * frames that match [testHelperExceptions]
   final bool createdByTestHelpers;
 
-  /// Stack frames that match this pattern, will not be treated as test helpers.
+  /// Stack frames that match this pattern will not be treated as test helpers.
   ///
   /// Is used to test functionality of
   /// the leak tracker.

pkgs/leak_tracker/lib/src/shared/shared_model.dart

@@ -122,9 +122,10 @@ class Leaks {
     final leaks = <String?, Map<LeakType, List<LeakReport>>>{};
     for (final entry in byType.entries) {
       for (final leak in entry.value) {
-        leaks[leak.phase] ??= {};
-        leaks[leak.phase]![entry.key] ??= [];
-        leaks[leak.phase]![entry.key]!.add(leak);
+        leaks
+            .putIfAbsent(leak.phase, () => {})
+            .putIfAbsent(entry.key, () => <LeakReport>[])
+            .add(leak);
       }
     }
     return {

pkgs/leak_tracker/test/tests/leak_tracking/_primitives/_test_helper_detector_test.dart

@@ -1,3 +1,7 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
 import 'package:leak_tracker/src/leak_tracking/primitives/_test_helper_detector.dart';
 import 'package:test/test.dart';
 
@@ -104,19 +108,19 @@ final _tests = [
     name: 'test-only factory method',
     isHelper: true,
     stackTrace: '''
-// #0      ObjectTracker.startTracking (package:leak_tracker/src/leak_tracking/_object_tracker.dart:69:31)
-// #1      LeakTracking.dispatchObjectCreated.<anonymous closure> (package:leak_tracker/src/leak_tracking/leak_tracking.dart:124:35)
-// #2      LeakTracking.dispatchObjectCreated (package:leak_tracker/src/leak_tracking/leak_tracking.dart:133:6)
-// #3      new LeakTrackedClass (package:leak_tracker_flutter_testing/src/test_classes.dart:40:18)
-// #4      new StatelessLeakingWidget (package:leak_tracker_flutter_testing/src/test_classes.dart:20:27)
-// #5      createTestWidget (file:///Users/polinach/_/leak_tracker/pkgs/leak_tracker_flutter_testing/test/tests/end_to_end/test_helpers_test.dart:46:46)
-// #6      main.<anonymous closure> (file:///Users/polinach/_/leak_tracker/pkgs/leak_tracker_flutter_testing/test/tests/end_to_end/test_helpers_test.dart:38:5)
-// #7      Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:215:19)
-// <asynchronous suspension>
-// #8      Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:213:7)
-// <asynchronous suspension>
-// #9      Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:258:9)
-// <asynchronous suspension>
+#0      ObjectTracker.startTracking (package:leak_tracker/src/leak_tracking/_object_tracker.dart:69:31)
+#1      LeakTracking.dispatchObjectCreated.<anonymous closure> (package:leak_tracker/src/leak_tracking/leak_tracking.dart:124:35)
+#2      LeakTracking.dispatchObjectCreated (package:leak_tracker/src/leak_tracking/leak_tracking.dart:133:6)
+#3      new LeakTrackedClass (package:leak_tracker_flutter_testing/src/test_classes.dart:40:18)
+#4      new StatelessLeakingWidget (package:leak_tracker_flutter_testing/src/test_classes.dart:20:27)
+#5      createTestWidget (file:///Users/polinach/_/leak_tracker/pkgs/leak_tracker_flutter_testing/test/tests/end_to_end/test_helpers_test.dart:46:46)
+#6      main.<anonymous closure> (file:///Users/polinach/_/leak_tracker/pkgs/leak_tracker_flutter_testing/test/tests/end_to_end/test_helpers_test.dart:38:5)
+#7      Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:215:19)
+<asynchronous suspension>
+#8      Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:213:7)
+<asynchronous suspension>
+#9      Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:258:9)
+<asynchronous suspension>
 ''',
   ),
 ];

pkgs/leak_tracker_flutter_testing/lib/src/testing_for_testing/README.md

@@ -1,4 +1,4 @@
-This forlder contains model and tests to test that methods like `testWidgets`,
+This folder contains model and tests to test that methods like `testWidgets`,
 that use API of this package, detect leaks as expected.
 
 See example of usage in [the test](../../../test/tests/end_to_end/testing_test.dart).

pkgs/leak_tracker_flutter_testing/lib/src/testing_for_testing/leaking_classes.dart

@@ -1,4 +1,4 @@
-// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 

pkgs/leak_tracker_flutter_testing/lib/src/testing_for_testing/test_case.dart

@@ -1,4 +1,4 @@
-// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 

pkgs/leak_tracker_flutter_testing/lib/src/testing_for_testing/test_settings.dart

@@ -1,4 +1,4 @@
-// Copyright (c) 2023, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 

pkgs/leak_tracker_flutter_testing/test/test_infra/memory_leak_tests.dart

@@ -1,6 +1,6 @@
-// Copyright 2014 The Flutter Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
 
 import 'package:flutter/cupertino.dart';
 import 'package:flutter/material.dart';
@@ -9,12 +9,12 @@ import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 import 'test_helpers.dart';
 
 /// Objects that should not be GCed during.
-final List<InstrumentedDisposable> _retainer = <InstrumentedDisposable>[];
+final _retainer = <InstrumentedDisposable>[];
 
 /// Test cases for memory leaks.
 ///
-/// They are separate from test execution to allow to except only them
-/// from test helpers.
+/// They are separate from test execution to allow to allow
+/// excluding them from test helpers.
 final List<LeakTestCase> memoryLeakTests = <LeakTestCase>[
   LeakTestCase(
     name: 'no leaks',

pkgs/leak_tracker_flutter_testing/test/test_infra/test_helpers.dart

@@ -1,10 +1,10 @@
-// Copyright 2014 The Flutter Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
 
 import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart';
 
-/// Test only function that create a leaking object.
+/// Test only function that creates a leaking object.
 ///
 /// If test helpers are ignored in leak tracking settings,
 /// leaks from objects created by this function will be ignored.

pkgs/leak_tracker_flutter_testing/test/tests/end_to_end/testing_test.dart

@@ -8,8 +8,11 @@ import 'package:test/test.dart';
 import '../../test_infra/memory_leak_tests.dart';
 
 class _TestExecution {
-  _TestExecution(
-      {required this.settings, required this.settingName, required this.test});
+  _TestExecution({
+    required this.settings,
+    required this.settingName,
+    required this.test,
+  });
 
   final String settingName;
   final LeakTesting settings;