This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add a Codec for the chunked transfer coding. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efortuna
suggested changes
Dec 6, 2016
| var size = end - start; | ||
| var sizeInHex = size.toRadixString(16); | ||
| var footerSize = isLast ? _doneChunk.length : 0; | ||
| var list = new Uint8List(sizeInHex.length + 2 + size + footerSize); |
There was a problem hiding this comment.
Why +2 here and line 65?
Consider making a descriptive variable name to clarify
| if (bytes[start] == $cr) { | ||
| _state = _State.beforeLF; | ||
| } else { | ||
| _size = (_size << 4) + _digitForByte(bytes, start); |
There was a problem hiding this comment.
consider making 4 a named constant so we don't just have a magic number here.
|
|
||
| /// A codec that encodes and decodes the [chunked transfer coding][]. | ||
| /// | ||
| /// [chunked transfer coding]: https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.6.1 |
There was a problem hiding this comment.
Why not make this a regular markdown link?
chunked transfer coding
or is this some syntax I'm just behind the times on?
| * Add `chunkedCoding`, a `Codec` that supports encoding and decoding the | ||
| [chunked transfer coding][]. | ||
|
|
||
| [chunked transfer coding]: https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.6.1 |
There was a problem hiding this comment.
Make it a Markdown link?
There was a problem hiding this comment.
This is a Markdown link 😊. Search for "implicit link name" in the syntax documentation.
efortuna
approved these changes
Dec 6, 2016
|
|
||
| /// A codec that encodes and decodes the [chunked transfer coding][]. | ||
| /// | ||
| /// [chunked transfer coding]: https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.6.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dart-lang/shelf#64