Enable Travis-CI #96
Enable Travis-CI #96
Conversation
|
@nex3 – made this green. At least a starting point for @donny-dont |
.travis.yml
Outdated
|
|
||
| matrix: | ||
| allow_failures: | ||
| - dart_task: dartanalyzer |
There was a problem hiding this comment.
Because there are still files that break analysis – specifically the multi_file things in the lib directory that aren't cleaned up yet
There was a problem hiding this comment.
Do we want to just allow failures at this point and then when everything is green then protect the branch?
There was a problem hiding this comment.
I don't think it makes sense to allow failures that are being actively worked on. I'd just let the bots be red until they go green.
.travis.yml
Outdated
| dart_task: | ||
| - test | ||
| - dartfmt | ||
| - dartanalyzer |
There was a problem hiding this comment.
Only run these once each. See the example file.
|
@kevmoo shoukd we cherry pick some of the 0.11.x commits before doing the dartfmt? |
|
I think Don's right... we shouldn't reformat before we merge stuff in from 0.11.x, or the conflicts will get out of control. Kevin, can you remove the formatting stuff for now? |
|
PTAL |
|
@kevmoo can we add whatever browser testing the dart team requires? The tests should run in both. |
|
Yeah, we should run tests on (at least) the VM and Firefox. |
|
PTAL
…On Mon, Jun 26, 2017 at 1:39 PM, Natalie Weizenbaum < ***@***.***> wrote:
Yeah, we should run tests on (at least) the VM and Firefox.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#96 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABCio7LVLYolHMaaG2gjqTiPYgP6fh3ks5sIBcTgaJpZM4OEHFx>
.
|
.travis.yml
Outdated
|
|
||
| dart_task: | ||
| - test: --platform vm | ||
| - test: --platform firefox |
There was a problem hiding this comment.
There aren't very many tests in this package, so it'll probably be faster if we run the VM and Firefox in the same task.
.travis.yml
Outdated
| - test: --platform vm | ||
| - test: --platform firefox | ||
| - dartfmt | ||
| - dartanalyzer |
There was a problem hiding this comment.
Since these are defined in the matrix section, they shouldn't be included here.
|
PTAL |
No description provided.