Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conformances test that verify that the Client works in Isolates #889

Merged
merged 10 commits into from
Mar 9, 2023
Merged

Add conformances test that verify that the Client works in Isolates #889

merged 10 commits into from
Mar 9, 2023

Conversation

brianquinlan
Copy link
Collaborator

No description provided.

@brianquinlan brianquinlan changed the title Add conformances test that very that the Client works in Isolates Add conformances test that verify that the Client works in Isolates Mar 9, 2023
@brianquinlan brianquinlan requested a review from natebosch March 9, 2023 16:28
natebosch
natebosch reviewed Mar 9, 2023
View reviewed changes
pkgs/http_client_conformance_tests/lib/src/isolate_test.dart Outdated
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:isolate';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this import break test compatibility on the web? I would expect to need conditional imports for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we don't block the import when we compile in the test runner, but we will block the import in google3 and with build_web_compilers.

I think we should fix that, but probably can't until we are ready for a major version bump. dart-lang/test#1968

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@brianquinlan brianquinlan merged commit 74f9d3d into dart-lang:master Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

Assignees

@natebosch natebosch

Labels
package:cronet_http package:cupertino_http Issues related to package:cupertino_http package:http_client_conformance_tests package:http
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianquinlan @natebosch