Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cascade implementation #88

Closed
wants to merge 2 commits into from

Conversation

donny-dont
Copy link

Adds the Cascade class and its associated tests

@donny-dont
Copy link
Author

This is dependent on #85

Enabling tests is dependent on dart-archive/package_resolver#4

Copy link
Member

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure a Cascade makes sense for http. It's important for shelf as a kind of super-simple routing, but I don't see a strong enough use-case for the client to warrant making it part of the core package.

@donny-dont
Copy link
Author

Ah okay in a previous conversation I swore you mentioned that as something to port. Your call if you want to close it as it was just a copy and paste from shelf with a couple modifications.

@nex3
Copy link
Member

nex3 commented Jun 22, 2017

It's possible I did—I've been known to make silly mistakes on occasion 😉. In any case, I've changed my mind, so I'm gonna close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants