Add a dart:html client #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
nex3
suggested changes
May 24, 2017
lib/browser_client.dart
Outdated
| Future<StreamedResponse> send(BaseRequest request) async { | ||
| var bytes = await request.finalize().toBytes(); | ||
| Future<Response> send(Request request) async { | ||
| var stream = new ByteStream(request.read()); |
There was a problem hiding this comment.
I really want to kill ByteStream, so we shouldn't use it here. You can pull this functionality into a function in utils/, although really it should live in a package somewhere.
There was a problem hiding this comment.
It appears it IS in a package 👍
lib/browser_client.dart
Outdated
| headers: xhr.responseHeaders, | ||
| reasonPhrase: xhr.statusText)); | ||
| reasonPhrase: xhr.statusText, | ||
| body: new ByteStream.fromBytes(body), |
There was a problem hiding this comment.
This also shouldn't be a ByteStream. In this case, just new Stream.fromIterable([body]) should work.
|
@nex3 |
?
|
Nice! Another one down 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the browser_client.dart implementation