-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly handle null
field values when encoding requests.
#77
Properly handle null
field values when encoding requests.
#77
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
lib/src/utils.dart
Outdated
@@ -30,6 +30,10 @@ Map/*<K, V>*/ updateMap/*<K, V>*/( | |||
/// mapToQuery({"foo": "bar", "baz": "bang"}); | |||
/// //=> "foo=bar&baz=bang" | |||
String mapToQuery(Map<String, String> map, {Encoding encoding}) { | |||
map.keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a local variable and do this in two steps. It'll be easier to read.
Also: please add a test that exercises this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both done. I don't have sdk v1.23 installed due to local requirements for 1.22, so I couldn't actually run the test suite, but the tests were super simple changes, so I don't expect any problems there.
CLAs look good, thanks! |
@kevmoo I don't see any references to |
3fffb44
to
da64c26
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@donny-dont you're totally right, my bad. I just pushed a rebase and changed the PR base. Also, not sure what happened to my cla... it was there... |
See #75 (comment) |
This fixes Issue #75