Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle null field values when encoding requests. #77

Closed

Conversation

bobjackman
Copy link

This fixes Issue #75

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -30,6 +30,10 @@ Map/*<K, V>*/ updateMap/*<K, V>*/(
/// mapToQuery({"foo": "bar", "baz": "bang"});
/// //=> "foo=bar&baz=bang"
String mapToQuery(Map<String, String> map, {Encoding encoding}) {
map.keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a local variable and do this in two steps. It'll be easier to read.

Also: please add a test that exercises this case.

Copy link
Author

@bobjackman bobjackman Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both done. I don't have sdk v1.23 installed due to local requirements for 1.22, so I couldn't actually run the test suite, but the tests were super simple changes, so I don't expect any problems there.

@googlebot
Copy link

CLAs look good, thanks!

@donny-dont
Copy link

@kevmoo I don't see any references to mapToQuery in master. Shouldn't this target the 0.11 branch?

@bobjackman bobjackman changed the base branch from master to 0.11.x April 17, 2017 23:59
@bobjackman bobjackman changed the base branch from 0.11.x to master April 18, 2017 00:00
@bobjackman bobjackman force-pushed the bugfix/null-request-params branch from 3fffb44 to da64c26 Compare April 18, 2017 00:07
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@bobjackman bobjackman changed the base branch from master to 0.11.x April 18, 2017 00:07
@bobjackman
Copy link
Author

@donny-dont you're totally right, my bad. I just pushed a rebase and changed the PR base.

Also, not sure what happened to my cla... it was there...

@nex3
Copy link
Member

nex3 commented May 15, 2017

See #75 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants