remove boundary characters that pkg:http_parser cannot parse #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
commented
Mar 29, 2017
| @@ -85,7 +85,7 @@ Future startServer() { | |||
| requestBody = requestBodyBytes; | |||
| } | |||
|
|
|||
| var content = { | |||
| var content = <String, dynamic>{ | |||
There was a problem hiding this comment.
FYI, the reason for this change was strong mode inferred the map as Map<String, Object> and then complained about expression content['headers'][name] on line 98, saying that Object lacks operator[].
kevmoo
requested changes
Mar 29, 2017
lib/src/multipart_request.dart
Outdated
| static const List<int> _BOUNDARY_CHARACTERS = const <int>[ | ||
| 39, 43, 95, 44, 45, 46, 58, 61, 63, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, | ||
| @visibleForTesting | ||
| static const List<int> BOUNDARY_CHARACTERS = const <int>[ |
There was a problem hiding this comment.
Better idea
- Put this in another file in src
- import here
- import via
lib/src/...in the test - Don't expose another top-level field
I was going to say exclude from 'lib/http.dart' but that's more error prone
There was a problem hiding this comment.
...then you don't need pkg/meta either 😄
yjbanov
force-pushed
the
remove-unparseable-boundary-chars
branch
from
9021c71 to
604f577
Compare
kevmoo
approved these changes
Mar 30, 2017
yjbanov
added a commit
to yjbanov/http
that referenced
this pull request
Mar 30, 2017
donny-dont
added a commit
to donny-dont/http
that referenced
this pull request
Jun 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
FYI, I'm not familiar with this project's setup. It seems the relevant code is on branch 0.11.x?
/cc @tvolkert @nex3