Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: fix broken links and BrowserClient example #38

Merged
merged 3 commits into from
Jul 6, 2016
Merged

README: fix broken links and BrowserClient example #38

merged 3 commits into from
Jul 6, 2016

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 16, 2016

  • BrowserClient link was missing. Added it.
  • Updated other links from api.dartlang.org to dartdocs.org.
  • BrowserClient example fixed: wrapped bare code in main function.

cc @kwalrath

@kwalrath
Copy link

LGTM. Thanks for the fixes!

I can merge unless someone else ( @nex3 ? @kevmoo ?) wants to do it.

nex3
nex3 reviewed Jun 20, 2016
View reviewed changes
README.md
print("Response status: ${response.statusCode}");
print("Response body: ${response.body}");
});
Future<Null> main() async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the return type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention that we have been following on the angular.io side has been to explicitly declare return types. In this case I find it quite useful for the return type to call out to a speed reader that main is async.

/cc @kwalrath @thso

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't yet adopted that convention for our packages, yet.

For now, remove the annotation. Should discuss in the context of our style guide.

chalin and others added 3 commits July 6, 2016 15:41
@chalin
README: fix broken links and BrowserClient example
0c18ba9 
- Updated links from api.dartlang.org to dartdocs.org.
- BrowserClient was missing.
- BrowserClient example: wrapped bare code in `main` function.
@chalin
Relocating definition of [BrowserClient]
e7550f4
@chalin
post-review update
fae3ed6
@chalin chalin force-pushed the chalin-README-updates-0615 branch from 7284a32 to fae3ed6 Compare July 6, 2016 22:43
@chalin
Copy link
Contributor Author

chalin commented Jul 6, 2016

@kevmoo : I removed the type annotation on main(), as requested.

@nex3 nex3 merged commit 6adaa03 into dart-lang:master Jul 6, 2016
@chalin chalin deleted the chalin-README-updates-0615 branch July 6, 2016 23:08
@aliaafreen aliaafreen mentioned this pull request Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalin @kwalrath @nex3 @kevmoo