Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single quote char (ASCII 39) causing failures with GCS #105

Closed
kevmoo opened this issue Jul 20, 2017 · 1 comment
Closed

single quote char (ASCII 39) causing failures with GCS #105

kevmoo opened this issue Jul 20, 2017 · 1 comment

Comments

@kevmoo
Copy link
Member

kevmoo commented Jul 20, 2017

Seems this is the root cause of the following

dart-lang/pub#1666
dart-lang/pub-dev#230

Solution: remove single quote from set of considered boundary characters
This was referenced Jul 20, 2017
Closed
Closed
kevmoo added a commit that referenced this issue Jul 20, 2017
@kevmoo
Remove "'" from boundary characters
0345f98 
Fixes #105
@kevmoo
Copy link
Member Author

kevmoo commented Jul 20, 2017

Can't figure out what this change dart-lang/sdk@ebffa49

Which included this range of changes 0.11.3+9...0.11.3+13 would cause this behavior to be exposed

This was referenced Jul 20, 2017
Merged
Closed
matanlurey pushed a commit that referenced this issue Jul 20, 2017
@kevmoo @matanlurey
Remove "'" from boundary characters (#106)
75579ce 
Fixes #105
@kevmoo kevmoo closed this as completed in ce2bdc6 Jul 29, 2017
@aliaafreen aliaafreen mentioned this issue Nov 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevmoo