Skip to content

Commit

Permalink
update package:dart_flutter_team_lints to use the beta package:lints (#…
Browse files Browse the repository at this point in the history
…179)

* update package:dart_flutter_team_lints to use the beta package:lints

* update pubspecs

* regenerate mono_repo files

* update package:lints dep

* Update pkgs/dart_flutter_team_lints/tool/dedup.dart

Co-authored-by: Nate Bosch <[email protected]>

* review feedback

---------

Co-authored-by: Nate Bosch <[email protected]>
  • Loading branch information
devoncarew and natebosch authored Sep 28, 2023
1 parent 297e63e commit 5b7d3fd
Show file tree
Hide file tree
Showing 9 changed files with 196 additions and 93 deletions.
98 changes: 33 additions & 65 deletions .github/workflows/dart.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkgs/blast_repo/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: blast_repo
description: A tool to bulk validate and fix GitHub repos.

publish_to: none

environment:
Expand All @@ -19,7 +20,7 @@ dependencies:
yaml_edit: ^2.1.0

dev_dependencies:
dart_flutter_team_lints: ^1.0.0
dart_flutter_team_lints: ^2.0.0
test: ^1.22.0
test_descriptor: ^2.0.0

Expand Down
5 changes: 3 additions & 2 deletions pkgs/corpus/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: corpus
description: A tool to calculate the API usage for a package.

publish_to: none

environment:
sdk: '>=2.19.0 <3.0.0'
sdk: ^3.0.0

dependencies:
analyzer: ^5.0.0
Expand All @@ -17,6 +18,6 @@ dependencies:

dev_dependencies:
checks: ^0.2.0
dart_flutter_team_lints: ^1.0.0
dart_flutter_team_lints: ^2.0.0
test: ^1.22.0
test_descriptor: ^2.0.0
6 changes: 6 additions & 0 deletions pkgs/dart_flutter_team_lints/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 2.1.0

- Updated to the preview `3.0.0-beta` version of package:lints/recommended.yaml.
- Removed lints duplicated from package:lints/core.yaml and
package:lints/recommended.yaml.

## 2.0.0

- Enable `strict-inference`.
Expand Down
20 changes: 0 additions & 20 deletions pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,51 +23,31 @@ analyzer:
linter:
rules:
# consistency
- avoid_empty_else
- avoid_shadowing_type_parameters
- avoid_types_as_parameter_names
- camel_case_extensions
- combinators_ordering
- curly_braces_in_flow_control_structures
- directives_ordering
- empty_catches
- file_names
- library_annotations
- lines_longer_than_80_chars
- omit_local_variable_types
- prefer_asserts_in_initializer_lists
- prefer_const_constructors
- prefer_generic_function_type_aliases
- prefer_is_empty
- prefer_relative_imports
- prefer_single_quotes
- prefer_typing_uninitialized_variables
- sort_pub_dependencies
- unnecessary_lambdas
- unnecessary_library_directive
- unnecessary_overrides
- unnecessary_parenthesis
- unnecessary_statements
- use_is_even_rather_than_modulo
- use_string_in_part_of_directives
- use_super_parameters

# correctness
- always_declare_return_types
- avoid_catching_errors
- avoid_dynamic_calls
- await_only_futures
- collection_methods_unrelated_type
- comment_references
- conditional_uri_does_not_exist
- dangling_library_doc_comments
- hash_and_equals
- implicit_call_tearoffs
- no_duplicate_case_values
- only_throw_errors
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
- unreachable_from_main
- unrelated_type_equality_checks
5 changes: 3 additions & 2 deletions pkgs/dart_flutter_team_lints/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
version: 2.0.0
version: 2.1.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints

environment:
sdk: ^3.0.0

dependencies:
lints: ^2.0.0
lints: ^3.0.0-0

dev_dependencies:
checks: ^0.2.0
path: ^1.8.0
test: ^1.0.0
yaml: ^3.0.0
Loading

0 comments on commit 5b7d3fd

Please sign in to comment.