-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #3784 into an 8.0.9+1 release #3800
Cherry-pick #3784 into an 8.0.9+1 release #3800
Conversation
352d5ba
to
3d4b6af
Compare
…sion of (dart-lang#3778) the analyzer package.
What is an aliased type parameter? Good question! `typedef TD<T> = T;` is such an alias. The fix is pretty simple, we just weren't previously handling this case, or being safe.
3d4b6af
to
cfa38d1
Compare
CC @dart-lang/analyzer-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand what's blocking the roll or why this fixes it, but I don't see anything that raises red flags, so I'm approving it. (I didn't look at the .js
files. I'm hoping those are generated and don't need a review.)
Ah yeah, there isn't a ticket, as far as I know, for the roll being blocked. 🤷 But the issue appears to be that:
|
The flutter roller is blocked and needs the fix in #3784 (14d33d3) released. Rather than cut a release with unrelated changes (with potential bugs), I'm cutting a cherry-pick release. This avoids ~10 commits between 8.0.9 and 14d33d3, and ~14 commits that have landed since the fix.
This PR actually contains three other cherry-pick commits that are necessary for CI (ddb8fb4, 3decf1e, ed97585) (CI was in a bad state right after 8.0.9 was released). They are all cherry-picked in the same order in which they appear on the main branch.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.