Preserve type aliases for records in output #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
changed the title
srawlins
approved these changes
Feb 16, 2023
test/typedef_test.dart
Outdated
|
|
||
| expect(fFunc.modelType.returnType, isA<AliasedUndefinedElementType>()); | ||
| expect( | ||
| (fFunc.modelType.returnType as AliasedUndefinedElementType) |
There was a problem hiding this comment.
This can be folded into the above expectation with having, I think.
isA<...>()
.having((e) => e.typeAliasElement, 'typeAliasElement', equals(rTypedef.element))There was a problem hiding this comment.
Ah, nice. Much better. Done.
test/end2end/model_test.dart
Outdated
| @@ -1538,7 +1538,7 @@ void main() { | |||
| expect( | |||
| B.documentationAsHtml, | |||
| contains( | |||
| '<p>Extends class <a href="${htmlBasePlaceholder}ex/Apple-class.html">Apple</a>, use <a href="${htmlBasePlaceholder}ex/Apple/Apple.html">new Apple</a> or <a href="${htmlBasePlaceholder}ex/Apple/Apple.fromString.html">new Apple.fromString</a></p>')); | |||
| '<p>Extends class <a href="${htmlBasePlaceholder}ex/Apple-class.html">Apple</a>, use <a href="${htmlBasePlaceholder}ex/Apple/Apple.html">Apple.Apple</a> or <a href="${htmlBasePlaceholder}ex/Apple/Apple.fromString.html">Apple.fromString</a></p>')); | |||
There was a problem hiding this comment.
I think these should be changed to Apple.new instead of Apple.Apple since Apple.Apple is not recognized by the analyzer (and thus the IDE). I don't think we need to test that this syntax works.
There was a problem hiding this comment.
Ah, good catch, yes this is a better choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to preserve the name of an alias when rendering typedefs referencing records, and a test. This builds on #3239 and implements the second half of this comment on #3122.
Doing this required or strongly suggested some refactoring. We now delegate
ElementTypeconstruction into factories forUndefinedElementTypeandDefinedElementType, which may make it more clear where to put these in the future. As part of this did the TODO to wipe out support for oldFunctionElementTypes that were backed by anElementsince that was a simple delete. I also added some sample code to the experiments package so dartdocs containing records can be checked for bugs by human eyes, while moving out "experimental" examples for constructor tearoffs that no longer need to be there.