Remove log.finest from source_gen. (dart-lang/source_gen#301)

dart-lang · Jan 22, 2018 · 6eac656 · 6eac656
1 parent 904a49d
commit 6eac656
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/pkgs/source_gen/CHANGELOG.md b/pkgs/source_gen/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 0.7.4+1
+
+* Removed a `log.finest` with the output source of each generator. This allows
+  a verbose option (`-v`) for tools like bazel or build_runner to be much more
+  readable and debuggable. Files are emitted to disk for inspection in any
+  case.
+
 ## 0.7.4
 
 * Added `typeNameOf`, which is a safe way to get the name of a `DartType`,

diff --git a/pkgs/source_gen/lib/src/builder.dart b/pkgs/source_gen/lib/src/builder.dart
@@ -224,7 +224,6 @@ Stream<GeneratedOutput> _generate(LibraryElement library,
       var createdUnit = await gen.generate(libraryReader, buildStep);
 
       if (createdUnit != null && createdUnit.isNotEmpty) {
-        log.finest(() => 'Generated $createdUnit for ${buildStep.inputId}');
         yield new GeneratedOutput(gen, createdUnit);
       }
     } catch (e, stack) {

diff --git a/pkgs/source_gen/pubspec.yaml b/pkgs/source_gen/pubspec.yaml
@@ -1,5 +1,5 @@
 name: source_gen
-version: 0.7.4
+version: 0.7.4+1
 author: Dart Team <[email protected]>
 description: Automated source code generation for Dart.
 homepage: https://github.com/dart-lang/source_gen